Skip to content

Conversation

@john-science
Copy link
Member

@john-science john-science commented Dec 17, 2025

What is the change? Why is it being made?

This PR improves the ARMI docs in a few different ways:

  • I believe the SCR was not building correctly on ARMI main, because the PR_NUMBER env variable was being set incorrectly in the doc.yaml file. This is why I had to pull PDFs from the PRs for this past ARMI release.
  • There was a gallery example that broke when we made the FAIL_ON_RANGE=True change.
  • Also, I refactored the automateSCR.py script to make it easier to run locally (I just made one of the arguments optional).

closes #2397

SCR Information

Change Type: docs

One-Sentence Rationale: The SCR should, ideally, build from PRs and from the main branch.

One-line Impact on Requirements: NA


Checklist

@john-science john-science removed the request for review from opotowsky December 17, 2025 22:25
@john-science john-science added the documentation Improvements or additions to documentation label Dec 17, 2025
@john-science john-science changed the title Scr trouble SCR trouble Jan 5, 2026
@john-science john-science changed the title SCR trouble Ensuring that SCRs will build correctly during main branch pushes Jan 6, 2026
@john-science john-science marked this pull request as ready for review January 6, 2026 18:10
@john-science john-science requested a review from opotowsky January 6, 2026 18:10
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SWEET so excited you have this fixed. You have 3 print statements in the PR still, unsure if you want to keep those or if they were just there for troubleshooting. I'll leave that up to you to delete, but it's non-blocking to my approval.

@john-science john-science merged commit e936b20 into main Jan 7, 2026
7 checks passed
@john-science john-science deleted the scr_trouble branch January 7, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Are the SCR docs broken on main?

3 participants