-
Notifications
You must be signed in to change notification settings - Fork 97
Ensuring that SCRs will build correctly during main branch pushes #2390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-science
commented
Jan 5, 2026
opotowsky
approved these changes
Jan 6, 2026
Member
opotowsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SWEET so excited you have this fixed. You have 3 print statements in the PR still, unsure if you want to keep those or if they were just there for troubleshooting. I'll leave that up to you to delete, but it's non-blocking to my approval.
john-science
commented
Jan 6, 2026
john-science
commented
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change? Why is it being made?
This PR improves the ARMI docs in a few different ways:
main, because thePR_NUMBERenv variable was being set incorrectly in thedoc.yamlfile. This is why I had to pull PDFs from the PRs for this past ARMI release.FAIL_ON_RANGE=Truechange.automateSCR.pyscript to make it easier to run locally (I just made one of the arguments optional).closes #2397
SCR Information
Change Type: docs
One-Sentence Rationale: The SCR should, ideally, build from PRs and from the main branch.
One-line Impact on Requirements: NA
Checklist
docfolder.pyproject.toml.